evolution on proposed API dropMetadata with vs code 1.82 #13009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note the API can't be fully implemented until next monaco upgrade Fixes eclipse-theia#12986 contributed on behalf of STMicroelectronics
rschnekenbu
force-pushed
the
issues/12986
branch
from
5f16e3a
to
59fdd6c
Compare
tsmaeder
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Some evolutions were done on proposed API dropMetadata with vs code 1.82:
This PR updated the proposal API and also the comments on the code where the code shall be updated on next monaco uplift.
Fixes #12986
Contributed on behalf of ST Microelectronics
How to test
There isn't anything to test, no behavior should have changed, as current Monaco version does not provide support to optional properties. Confirm that the changes in #12125 still work as expected.
Follow-ups
Monaco uplift tag has been updated for when the monaco version is uplifted.
Review checklist
Reminder for reviewers